Add WithMirrors option to append lifecycle - #1077
Merged
AlCutter merged 4 commits intoJul 24, 2026
Merged
Conversation
AlCutter
force-pushed
the
mirror_mirror_op_tion_al
branch
from
July 24, 2026 11:42
e8d487e to
1663c67
Compare
roger2hk
approved these changes
Jul 24, 2026
| if err != nil { | ||
| return nil, err | ||
| eg := errgroup.Group{} | ||
| sigC := make(chan []byte, 2) |
Contributor
There was a problem hiding this comment.
nit: Using channel seems to be an overkill here. It can be replaced by:
var ws, ms []byte
...
...
...
cp = append(cp, ws...)
cp = append(cp, ms...)
Collaborator
Author
There was a problem hiding this comment.
Done, but meh :)
The assignments are a little more prone to future bugs (e.g. cut-n-paste assigning to the wrong var), but I don't feel very strongly about it.
Comment on lines
+988
to
+995
| // WithMirrors configures the set of tlog-mirror servers that Tessera will contact in order to obtain | ||
| // mirror counter-signatures on a checkpoint before publishing it. | ||
| // | ||
| // Requests will be sent to every mirror referenced by the group using the tlog-mirror API at the configured URL. | ||
| // The checkpoint will be accepted for publishing when a sufficient number of mirrors to satisfy the group | ||
| // have responded. | ||
| // | ||
| // If this method is not called, then no mirror counter signatures will be required to publish. |
Contributor
There was a problem hiding this comment.
Suggested change
| // WithMirrors configures the set of tlog-mirror servers that Tessera will contact in order to obtain | |
| // mirror counter-signatures on a checkpoint before publishing it. | |
| // | |
| // Requests will be sent to every mirror referenced by the group using the tlog-mirror API at the configured URL. | |
| // The checkpoint will be accepted for publishing when a sufficient number of mirrors to satisfy the group | |
| // have responded. | |
| // | |
| // If this method is not called, then no mirror counter signatures will be required to publish. | |
| // WithMirrors configures the set of tlog-mirror servers that Tessera will contact in order to obtain | |
| // mirror countersignatures on a checkpoint before publishing it. | |
| // | |
| // Requests will be sent to every mirror referenced by the group using the tlog-mirror API at the configured URL. | |
| // The checkpoint will be accepted for publishing when a sufficient number of mirrors to satisfy the group | |
| // have responded. | |
| // | |
| // If this method is not called, then no mirror countersignatures will be required to publish. |
Update to countersignatures for spelling consistency (counter signatures, counter-signatures).
AlCutter
force-pushed
the
mirror_mirror_op_tion_al
branch
from
July 24, 2026 12:28
68735fc to
677f008
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure mirroring in the append lifecycle.
Since mirrors are witnesses with special powers, we use the same mechanism as
WithWitnessesto describe the policy.The implementation of the client/gateway code will come later.
Towards #945